Skip to content

Fix svelte transformer #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ije merged 2 commits into from
May 12, 2026
Merged

Fix svelte transformer #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adce55a
Fix sevlte SFC transforming
ije May 12, 2026
a6ad148
Add testings
ije May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions server/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,11 @@ func (ctx *BuildContext) buildModule(analyzeMode bool) (meta *BuildMeta, include
if err != nil {
return esbuild.OnLoadResult{}, err
}
return esbuild.OnLoadResult{Contents: &out.Code, Loader: esbuild.LoaderJS}, nil
return esbuild.OnLoadResult{
Contents: &out.Code,
ResolveDir: path.Join(ctx.wd, "node_modules", ctx.esmPath.PkgName),
Loader: esbuild.LoaderJS,
}, nil
Comment thread
ije marked this conversation as resolved.
},
)

Expand Down Expand Up @@ -1024,9 +1028,17 @@ func (ctx *BuildContext) buildModule(analyzeMode bool) (meta *BuildMeta, include
return esbuild.OnLoadResult{}, err
}
if out.Lang == "ts" {
return esbuild.OnLoadResult{Contents: &out.Code, Loader: esbuild.LoaderTS}, nil
return esbuild.OnLoadResult{
Contents: &out.Code,
ResolveDir: path.Join(ctx.wd, "node_modules", ctx.esmPath.PkgName),
Loader: esbuild.LoaderTS,
}, nil
Comment thread
ije marked this conversation as resolved.
}
return esbuild.OnLoadResult{Contents: &out.Code, Loader: esbuild.LoaderJS}, nil
return esbuild.OnLoadResult{
Contents: &out.Code,
ResolveDir: path.Join(ctx.wd, "node_modules", ctx.esmPath.PkgName),
Loader: esbuild.LoaderJS,
}, nil
},
)
},
Expand Down
14 changes: 14 additions & 0 deletions test/issue-1233/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { assertEquals, assertStringIncludes } from "jsr:@std/assert";

Deno.test("issue #1233 - Svelte loader", async () => {
{
const res = await fetch(
"http://localhost:8080/@onsvisual/svelte-components@1.1.20/dist/components/Section/Section.svelte",
{ headers: { "User-Agent": "i'm a browser" } },
Comment thread
ije marked this conversation as resolved.
);
const js = await res.text();
assertEquals(res.status, 200);
assertEquals(res.headers.get("content-type"), "application/javascript; charset=utf-8");
assertStringIncludes(js, '/js/utils?target=es2022');
}
});
Loading