-
Notifications
You must be signed in to change notification settings - Fork 4
Tweaking the CI settings #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9daa830 to
48aa3dc
Compare
d6e38a1 to
4b756a0
Compare
|
I'm not sure from a review perspective, what version of Ruby is required? Since this affects users, it's different from just tweaking CI settings. It would be good to specify |
|
@koic Good question! I think no one has decided which Ruby versions this gem supports. I don't foresee a major problem with leaving it unspecified for now, but happy to change this if someone needs it. In this PR, I limited the number of combinations of Ruby and ActiveJob in the CI just because some newer ActiveJob versions require newer Ruby. |
|
I think the minimum Ruby version tested in CI matrix should match the |
|
For example, since the current |
|
That's a good point. Added 🙏 |
require 'logger'to fix errors (like this) in some older versions of ActiveJobruby x active_jobcombinations for too older versions