This repository was archived by the owner on Feb 22, 2020. It is now read-only.
DECIMAL columns to float and the query buffer automatically enlarged. - #64
Open
ionutgrigorescu wants to merge 2 commits into
Open
DECIMAL columns to float and the query buffer automatically enlarged.#64ionutgrigorescu wants to merge 2 commits into
ionutgrigorescu wants to merge 2 commits into
Conversation
… of things. FIX: the DECIMAL and NEWDECIMAL will be converted to float.
…ehaviour was:
// Socket buffer got full!
setError("Socket receive buffer full", 0, UME_OTHER);
return false;
-- this ended in a python script forced exit.
I changed the behaviour to resizing the buffer to double it's old size.
--a big query can expect more data, so this saves newer allocation times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// Socket buffer got full!
setError("Socket receive buffer full", 0, UME_OTHER);
return false;
-- this ended in a python script forced exit.
I added char * PacketReader::resizeBuffer(size_t new_size) to be able to resize the buffer, and in the case of a big query, when the buffer get's filled, the bool Connection::readSocket() method will automatically resize the buffer to twice it's size. A big query can expect more data, so this saves newer allocation times.