feat(notifications): Implement one-click unsubscribe and enhance management command by thejoeejoee · Pull Request #360 · esnvutbrno/fiesta-plus

thejoeejoee · 2026-03-08T09:59:15Z

Follow-up to #357 — rebased onto feat-notifications.

Resolves #359.

Changes

RFC 8058 one-click unsubscribe — signed token flow (generate → email header → POST handler → preference update), unsubscribe view with GET confirmation + POST action, template with {% block main %}.

Management command hardening — --batch-size / --dry-run flags, select_for_update(skip_locked=True) for concurrent safety, deterministic order_by('send_after', 'pk'), per-notification error handling with sent_at rollback on failure.

Bug fixes — token signs User.pk (not UserProfile.pk), preference filter uses .user FK correctly, POST errors return 400 (not 200), request typed as HttpRequest.

Cleanup — models/factories/tests aligned to User-based recipient, removed dead _create_profile helper + unused logger import.

…okens

…un, and error resilience

…sed recipient

coderabbitai · 2026-03-08T09:59:36Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 157ffc52-c361-475d-b33b-f178cc735fd6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat-notifications-flup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…e block name

Copilot

Pull request overview

Implements one-click unsubscribe support for notification emails (List-Unsubscribe headers + unsubscribe endpoint) and enhances the scheduled-notifications management command with batching, dry-run, and improved concurrency behavior.

Changes:

Add signed unsubscribe token service + public unsubscribe GET/POST view and URL route.
Add List-Unsubscribe/List-Unsubscribe-Post headers and unsubscribe link to notification email templates.
Enhance send_scheduled_notifications command (batch size, dry-run, skip_locked locking) and update scheduled-notification model/tests accordingly.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
fiesta/apps/notifications/views.py	Adds `UnsubscribeView` for token-based unsubscribe flows.
fiesta/apps/notifications/urls.py	Routes unsubscribe URLs to the new view.
fiesta/apps/notifications/tests/test_unsubscribe.py	Adds tests for token service, unsubscribe view, and email headers.
fiesta/apps/notifications/tests/test_scheduler.py	Updates scheduler tests to use `NotificationKind` and ensure profiles exist.
fiesta/apps/notifications/tests/test_scheduled_command.py	Extends command tests for skip_locked, dry-run, batch sizing, and error handling.
fiesta/apps/notifications/tests/test_membership_notifications.py	Updates membership notification tests for `NotificationKind` and profile creation.
fiesta/apps/notifications/tests/test_match_notifications.py	Updates match notification tests for `NotificationKind` and profile creation.
fiesta/apps/notifications/tests/factories.py	Updates factories to use `NotificationKind` and adjust user/profile creation.
fiesta/apps/notifications/templates/notifications/unsubscribe.html	Adds unsubscribe confirmation/success/error page.
fiesta/apps/notifications/templates/notifications/base_email.txt	Adds unsubscribe link to plaintext email footer.
fiesta/apps/notifications/templates/notifications/base_email.html	Adds unsubscribe link to HTML email footer.
fiesta/apps/notifications/services/unsubscribe.py	Adds token generation/verification service using `TimestampSigner`.
fiesta/apps/notifications/services/scheduler.py	Tweaks global opt-out check to suppress missing-profile attribute errors.
fiesta/apps/notifications/services/mailer.py	Injects `unsubscribe_url` into email context and sets List-Unsubscribe headers.
fiesta/apps/notifications/models/scheduled.py	Uses swappable `AUTH_USER_MODEL` FK and makes `section` nullable.
fiesta/apps/notifications/migrations/0002_alter_sectionnotificationpreferences_options_and_more.py	Migration to reflect scheduled-notification model field changes.
fiesta/apps/notifications/management/commands/send_scheduled_notifications.py	Adds batch size + dry-run; uses `skip_locked` row-lock claiming and improved accounting/logging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

fiesta/apps/notifications/views.py

fiesta/apps/notifications/tests/test_unsubscribe.py

fiesta/apps/notifications/management/commands/send_scheduled_notifications.py

fiesta/apps/notifications/services/unsubscribe.py

fiesta/apps/notifications/tests/factories.py

fiesta/apps/notifications/views.py

fiesta/apps/notifications/tests/test_unsubscribe.py

fiesta/apps/notifications/management/commands/send_scheduled_notifications.py

…ping, lock contention, dead code)

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-08T11:20:58Z

fiesta/apps/notifications/services/mailer.py

+    email_context = dict(context)
+    unsubscribe_url = ""
+    if recipient_user is not None:
+        token = generate_unsubscribe_token(recipient_user.pk)
+        unsubscribe_url = f"https://{settings.ROOT_DOMAIN}/notifications/unsubscribe/{token}/"
+


send_notification_email always generates an unsubscribe_url when recipient_user is provided, even if that user has no UserProfile (the function explicitly allows sending when the profile is missing). In that case the unsubscribe link will reliably 400 because UnsubscribeView looks up UserProfile and treats DoesNotExist as an invalid link. Consider only adding unsubscribe_url/List-Unsubscribe headers when a profile exists, or update the unsubscribe view to handle users without a profile (e.g., create one or persist the opt-out on the User model).

Copilot · 2026-03-08T11:20:58Z

fiesta/apps/notifications/views.py

+        logger.warning("Unsupported unsubscribe action %r for user_profile=%s", action, user_profile.pk)
+


For unsupported/unknown action values, _unsubscribe only logs a warning and returns without changing any preferences, but the POST handler will still render the success page. That can falsely tell users they unsubscribed when nothing happened. Consider treating unknown actions as invalid (render an error / 400) or mapping them to a safe default behavior.

Copilot · 2026-03-08T11:20:58Z

fiesta/apps/notifications/views.py

+                "action": action,
+                "action_description": self._action_description(action),
+                "email": user_profile.user.email,
+            },
+        )


The GET confirmation page renders the user’s full email address based solely on possession of the token. If an unsubscribe link is forwarded or leaked, this unnecessarily discloses PII. Consider omitting the email entirely or masking it (e.g., a***@domain.tld) in the template context.

Copilot · 2026-03-08T11:20:58Z

fiesta/apps/notifications/management/commands/send_scheduled_notifications.py

        # Phase 1: Atomically claim pending notifications by stamping sent_at.
        # select_for_update(skip_locked=True) + immediate UPDATE prevents concurrent
        # workers from picking the same rows (locks held only for the UPDATE, not I/O).
        with transaction.atomic():


The new “claim” mechanism sets sent_at=now before any email I/O occurs. If the process crashes or is killed after claiming but before sending/rollback, those notifications will look sent and will never be retried, causing silent message loss. Consider introducing a separate claim field (e.g., claimed_at/locked_at), or only setting sent_at after a successful send while using another durable marker to prevent concurrent workers.

thejoeejoee added 3 commits March 8, 2026 10:12

feat(notifications): add RFC 8058 one-click unsubscribe with signed t…

969b33f

…okens

feat(notifications): harden management command with batch-size, dry-r…

1276814

…un, and error resilience

chore(notifications): align models, factories, and tests with User-ba…

0624764

…sed recipient

thejoeejoee requested a review from Copilot March 8, 2026 09:59

Copilot started reviewing on behalf of thejoeejoee March 8, 2026 09:59 View session

fix(notifications): resolve unsubscribe token/PK mismatch and templat…

540b0bb

…e block name

Copilot AI reviewed Mar 8, 2026

View reviewed changes

fix(notifications): address PR #360 review findings (status codes, ty…

8ab3e22

…ping, lock contention, dead code)

thejoeejoee requested a review from Copilot March 8, 2026 11:15

Copilot started reviewing on behalf of thejoeejoee March 8, 2026 11:15 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(notifications): Implement one-click unsubscribe and enhance management command#360

feat(notifications): Implement one-click unsubscribe and enhance management command#360
thejoeejoee wants to merge 5 commits intofeat-notificationsfrom
feat-notifications-flup

thejoeejoee commented Mar 8, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 8, 2026 •

edited

Loading

Review skipped

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		logger.warning("Unsupported unsubscribe action %r for user_profile=%s", action, user_profile.pk)

Conversation

thejoeejoee commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

coderabbitai bot commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thejoeejoee commented Mar 8, 2026 •

edited

Loading

coderabbitai bot commented Mar 8, 2026 •

edited

Loading