allows to specify spi transfer_size chunk length#168
Draft
Vollbrecht wants to merge 14 commits intoesp-rs:masterfrom
Draft
allows to specify spi transfer_size chunk length#168Vollbrecht wants to merge 14 commits intoesp-rs:masterfrom
Vollbrecht wants to merge 14 commits intoesp-rs:masterfrom
Conversation
MabezDev
reviewed
Dec 12, 2022
MabezDev
approved these changes
Dec 12, 2022
Member
|
Sorry for the delay @Vollbrecht, would you mind fixing the conflicts one last time? |
Member
|
Hi @Vollbrecht, would you mind rebasing this PR to fix the conflicts? |
Collaborator
Author
yeah i will get there the next days. was kinda busy the last weeks. need to also spin up some hardware test afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if dma is not enabled the max_transfer size is used to determine the transfer chunk size. this is 64 bits. -> every transaction shorter than 64 bits will be clocked out with continuous 64 clk cycle. often devices on spi wants an 8bit chunked version.
Before Patch:
With Patch:
