Separate the configuration of rx and tx slots for I2S in tdm mode#436
Open
Volkalex28 wants to merge 1 commit intoesp-rs:masterfrom
Open
Separate the configuration of rx and tx slots for I2S in tdm mode#436Volkalex28 wants to merge 1 commit intoesp-rs:masterfrom
Volkalex28 wants to merge 1 commit intoesp-rs:masterfrom
Conversation
Volkalex28
force-pushed
the
i2s_split_tdm_slots_cfg
branch
from
269e4f8 to
9c36c45
Compare
Collaborator
|
@Volkalex28 Would you mind if this waits until after we do the upcoming release? |
Contributor
Author
|
@ivmarkov Do you mean releasing patch .1 in a few days or delaying it until the next release? |
Collaborator
What do you mean by |
Contributor
Author
|
@ivmarkov I got you. If it doesn't take more than two weeks, that's fine for me. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rx and Tx slots can have different configurations for the same I2S
So far I have added this only for tdm mode, let me know if this needs to be done for std as well