Fix I2S compilation on IDF 6.0-beta2#89
Merged
stuartparmenter merged 2 commits intomainfrom Feb 12, 2026
Merged
Conversation
The conditional from the cherry-pick only included soc/i2s_periph.h for IDF >= 5.4.0, leaving IDF 4.x without it. Change the elif to else so all non-6.0 versions get the header. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
datagutt
pushed a commit
to datagutt/esp-hub75
that referenced
this pull request
Feb 15, 2026
* fix: i2s compilation on IDF 6.0-beta2 * Fix i2s_periph.h include for IDF 4.x The conditional from the cherry-pick only included soc/i2s_periph.h for IDF >= 5.4.0, leaving IDF 4.x without it. Change the elif to else so all non-6.0 versions get the header. --------- Co-authored-by: Aiden <aiden@vigue.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of acvigue@b11a95b from @acvigue (referenced in #88).
esp_driver_i2sdependency for ESP32/ESP32-S2 targets when building with IDF 6.0+drivercomponent from the requirements list for IDF 6.0+soc/i2s_periph.his no longer availableTested on IDF 6.0-beta2 by @acvigue. CI will verify IDF 4.x, 5.x, and 6.0-beta1 compatibility.