Conversation
✅ Deploy Preview for esphome-devices ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds device documentation for the Seeed Studio WT32-SC01, an ESP32 development board with a 3.5" TFT LCD touchscreen display. The device features an ESP32-S3 chip with PSRAM and includes both display and touch interface capabilities.
- Adds complete hardware configuration for the WT32-SC01 display and touch components
- Includes SPI bus configuration for the ST7796 display controller
- Provides I2C configuration for the FT63x6 touch controller with LVGL integration
| difficulty: 2 | ||
| --- | ||
|
|
||
| https://www.seeedstudio.com/ESP32-Development-board-WT32-SC01-p-4735.html |
There was a problem hiding this comment.
The device documentation should include a proper description of the device features and capabilities, not just a bare URL. Consider adding a brief description above the purchase link.
There was a problem hiding this comment.
Good idea. Go to that link and create summary about this board.
|
|
||
| ``` | ||
| esphome: | ||
| name: test |
There was a problem hiding this comment.
The esphome name should use a more descriptive name than 'test'. For device documentation, consider using a name that reflects the device, such as 'wt32-sc01' or similar.
| scl: GPIO19 # TOUCH_SCL | ||
| frequency: 400kHz # From original code | ||
|
|
||
| font: |
There was a problem hiding this comment.
The configuration includes font, display, touchscreen, and LVGL components which go beyond hardware definitions. According to guidelines, the first configuration should contain hardware definitions only. Consider moving display/touch configuration and LVGL setup to a separate configuration block.
| id(y_marker).set_points({ {0, touch.y}, {480, touch.y} }); | ||
|
|
||
|
|
||
| lvgl: |
There was a problem hiding this comment.
LVGL configuration with widgets and touch handlers represents complex functionality beyond basic hardware setup. This should be moved to a separate configuration example block after the basic hardware configuration.
| output: display_backlight_pwm | ||
| id: display_backlight | ||
| restore_mode: ALWAYS_ON | ||
| internal: True |
There was a problem hiding this comment.
In ESPHome YAML, boolean values should be lowercase. Change 'True' to 'true'.
| internal: True | |
| internal: true |
1 participant
Brief description of the changes
Added new device Seeed Studio WT32-SC01
Type of changes
Checklist:
The only exceptions are
!secret wifi_ssidand!secret wifi_password.wifiorethernetblock has no static / manual ip address specified.A more involved example can be provided in a separate configuration block.