-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the time unit that a template should return #4732
base: current
Are you sure you want to change the base?
Conversation
In `deep_sleep.enter`, **sleep_durartion** is templatable but the unit is never provided. This commit clarifies that it should be in ms.
WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DeepSleepAction
participant LambdaEvaluator
participant SleepService
User->>DeepSleepAction: Call deep_sleep.enter with templated sleep_duration
DeepSleepAction->>LambdaEvaluator: Evaluate lambda for sleep_duration
LambdaEvaluator-->>DeepSleepAction: Return sleep duration in milliseconds
DeepSleepAction->>SleepService: Enter sleep mode for computed duration
SleepService-->>DeepSleepAction: Confirm sleep mode initiated
DeepSleepAction-->>User: Operation complete
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)`**`: - Do not generate or add any sequence diagrams
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Description:
In
deep_sleep.enter
, sleep_durartion is templatable but the unit is never provided. This commit clarifies that it should be in ms.Reference: esphome/esphome@da82562
Related issue (if applicable): N/A
Pull request in esphome with YAML changes (if applicable): N/A
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rst
when creating new documents for new components or cookbook.