-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tuya Select - Add data_type #4749
base: current
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates the Tuya select platform documentation by introducing a new optional configuration parameter, Changes
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
components/select/tuya.rst (2)
43-43
: Ensure YAML Example Clarity fordata_type
.The YAML example now includes the
data_type: enum
line, which is consistent with the new parameter functionality. Consider adding a brief inline comment or an external documentation note explaining that users may also change this value toint
if needed, to prevent any ambiguity.
59-59
: Clarifydata_type
Usage in Configuration Variables.The new configuration variable description clearly states the allowed values (
enum
orint
) and the default setting. To further assist users, consider expanding the description with a short note on how the backing data type affects the select component's behavior.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/select/tuya.rst
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**`: - Do not generate or add any sequence diagrams
**
: - Do not generate or add any sequence diagrams
components/select/tuya.rst
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Description:
Allow configuration of backing data type for Tuya Select, expanding from
enum
to also allowingint
Related issue (if applicable): fixes N/A
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rst
when creating new documents for new components or cookbook.