Fix LEDs stuck on startup twinkle #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firmware built successfully! 🎉 Download and extract the firmware to install with https://web.esphome.io Make sure to choose |
|
Firmware built successfully! 🎉 Download and extract the firmware to install with https://web.esphome.io Make sure to choose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a delay connecting to wifi, Improv BLE (and the captive portal) may start, activating the twinkle effect. If, however, wifi does connect after a delay, Improv will stop without triggering
on_provisioned. This results in the LEDs getting stuck on the start-up effect and never advancing.This PR corrects this behavior by adding the
on_stoptrigger to Improv, allowing the subsequent effects to be visible.