Conversation
Contributor
Author
|
Hello @jesserockz, seems that you were involved in PRs. Sorry if it is not you ... |
Member
|
While your changes are valid, I would expect the original config to be valid. If it is not now but once was, then someone broke it. I will take a look when I can at the esphome code |
|
Wondering if this has been fixed. I am unable to get my device to connect because of the issue. |
jesserockz
approved these changes
Apr 30, 2025
Member
jesserockz
left a comment
jesserockz
left a comment
There was a problem hiding this comment.
Apologies, I am going to merge this now, but ESPHome 2025.4.2 will have the actions fixed. It was a small oversight on a large PR that broke it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix configuration for muse luxe linked to issue #65