refactor(bt): Refactor BT Classic and BLE#12564
Open
lucasssvaz wants to merge 1 commit into
Open
Conversation
lucasssvaz
added
Area: BT classic
lucasssvaz
requested review from
a team,
P-R-O-C-H-Y,
SuGlider and
pedrominatel
as code owners
Contributor
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lucasssvaz
force-pushed
the
feat/bt_refactor
branch
from
169b47a to
37934c4
Compare
lucasssvaz
force-pushed
the
feat/bt_refactor
branch
2 times, most recently
from
a5bdf45 to
84bbebe
Compare
Contributor
Test Results 108 files 108 suites 42m 48s ⏱️ For more details on these failures, see this check. Results for commit 1b0545b. ♻️ This comment has been updated with latest results. |
4 tasks
lucasssvaz
force-pushed
the
feat/bt_refactor
branch
2 times, most recently
from
3af5158 to
027a607
Compare
Contributor
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucasssvaz
force-pushed
the
feat/bt_refactor
branch
from
027a607 to
1b0545b
Compare
Collaborator
This is a potential problem, considering the size of this PR. @lucasssvaz - is it possible to break this PR into smaller changes and submit one at a time, in order to allow CoPilot to review and also make it better for us for reviewing? |
SuGlider
reviewed
May 12, 2026
Collaborator
SuGlider
left a comment
SuGlider
left a comment
There was a problem hiding this comment.
@lucasssvaz - Please consider splitting this PR into many smaller target-centric changes.
Member
Author
|
@SuGlider The BLE changes are all dependent on each other as it fully reworks the classes structures. The most I can do is to separate the BT Classic changes, tests and documentation but this won't put the number of lines under 20k. For this PR we won't be able to rely on copilot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR is a large-scale architectural overhaul of the BLE and BluetoothSerial libraries. The goal is to cleanly separate stack-specific implementation details behind a unified public API, remove legacy utility bloat, introduce fail-closed validation, and substantially expand test coverage.
The library internals have been reorganized under libraries/BLE/src/impl/ using the PIMPL pattern. Public headers are now stack-agnostic; all Bluedroid- and NimBLE-specific code lives under impl/bluedroid/ and impl/nimble/ respectively, dispatched via backend headers (BLEAdvertisingBackend.h, BLECharacteristicBackend.h, etc.).
Note
This PR does not represent the final version of the refactor. Many optimizations and changes are still pending. Feedback is appreciated.
To Do:
#9878
Test Scenarios
Tested locally. Both validation tests pass consistently.