fix(esp_lvgl_port): Register button callbacks only if encoder_enter is set (BSP-675) #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
mpmarfisi
changed the title
espzav
reviewed
May 13, 2025
There was a problem hiding this comment.
@mpmarfisi Thank you for this fix. LGTM
Please remove version change (we will release esp_lvgl_port later with updated CHANGELOG file)
|
@espzav done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
When registering an encoder an encoder using
lvgl_port_add_encoder(const lvgl_port_encoder_cfg_t * encoder_cfg), ifencoder_cfg->encoder_enterisNULL, button callbacks are still registered. This can lead to unintended behavior if no "enter" handler is expected.