Sensor hub API#718
Conversation
61cadc7 to
fb405a8
Compare
Test Results28 tests 28 ✅ 1m 18s ⏱️ Results for commit 627ce5c. ♻️ This comment has been updated with latest results. |
fb405a8 to
e3fc3ae
Compare
e3fc3ae to
a8808a5
Compare
a0723b9 to
589c657
Compare
espzav
left a comment
There was a problem hiding this comment.
I made first fast round and left some comments.
-Do we really need public API for sensors?
- For example
icm42670doesn't need anything in header file. Same foraht30 - Can we move
icm42670into sensor/ too? - We should add
aht30intoupload_component.yml
589c657 to
4a0dae5
Compare
I think that we should have public API for these sensors because they are also components all by themselves and that way we eliminate the need to use them with the sensor hub (which we use at the moment but we might switch to something else in the future).
Yeah, done.
Good point. Done. |
ebddeca to
39b546a
Compare
|
cursor review |
|
Skipping Bugbot: Bugbot is globally disabled for this team |
cbeaddd to
ab4c5c7
Compare
ab4c5c7 to
8092986
Compare
8092986 to
603cdce
Compare
|
cursor review |
a68213f to
e64e6f0
Compare
e64e6f0 to
627ce5c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
ESP-BSP Pull Request checklist
Change description
Extended the ICM42670 driver with sensor hub
Added an AHT30 driver
Added an example of sensor hub usage
Note
Medium Risk
Introduces new I2C bus initialization and a new BSP-level sensor API plus new sensor components, which could affect board bring-up and component packaging if misconfigured. Changes are additive and largely isolated to ESP-BOX-3 and the new sensor drivers.
Overview
Adds a new sensor hub integration path across the repo: a new
components/sensors/aht30temperature/humidity driver (with sensor-hub detect/impl hooks) and updatescomponents/sensors/icm42670to expose sensor-hub implementation hooks and declare asensor_hubdependency.Extends the
esp-box-3BSP to advertiseBSP_CAPS_HUMITURE, create a newbsp_sensor_init()API, and initialize a second “dock” I2C bus so IMU (icm42670) and humiture (aht30) sensors can be instantiated viaiot_sensor_create().Adds a new
examples/sensorsapp demonstrating polling + event callbacks for IMU and humiture sensors, and updates generated docs/README tables and CI/workflow metadata (component upload list, build-test rules, capability/feature emoji mapping) to include the newHUMITUREfeature and new sensor components.Written by Cursor Bugbot for commit 627ce5c. This will update automatically on new commits. Configure here.