Skip to content

Sensor hub API#718

Merged
PetrESP merged 4 commits into
masterfrom
feat/ICM42607_sensor_hub_api
Feb 17, 2026
Merged

Sensor hub API#718
PetrESP merged 4 commits into
masterfrom
feat/ICM42607_sensor_hub_api

Conversation

@PetrESP
Copy link
Copy Markdown
Collaborator

@PetrESP PetrESP commented Jan 30, 2026

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

Extended the ICM42670 driver with sensor hub
Added an AHT30 driver
Added an example of sensor hub usage


Note

Medium Risk
Introduces new I2C bus initialization and a new BSP-level sensor API plus new sensor components, which could affect board bring-up and component packaging if misconfigured. Changes are additive and largely isolated to ESP-BOX-3 and the new sensor drivers.

Overview
Adds a new sensor hub integration path across the repo: a new components/sensors/aht30 temperature/humidity driver (with sensor-hub detect/impl hooks) and updates components/sensors/icm42670 to expose sensor-hub implementation hooks and declare a sensor_hub dependency.

Extends the esp-box-3 BSP to advertise BSP_CAPS_HUMITURE, create a new bsp_sensor_init() API, and initialize a second “dock” I2C bus so IMU (icm42670) and humiture (aht30) sensors can be instantiated via iot_sensor_create().

Adds a new examples/sensors app demonstrating polling + event callbacks for IMU and humiture sensors, and updates generated docs/README tables and CI/workflow metadata (component upload list, build-test rules, capability/feature emoji mapping) to include the new HUMITURE feature and new sensor components.

Written by Cursor Bugbot for commit 627ce5c. This will update automatically on new commits. Configure here.

@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch from 61cadc7 to fb405a8 Compare January 30, 2026 14:20
Comment thread components/sensor/aht30/aht30.c Outdated
Comment thread bsp/esp-box-3/esp-box-3.c
Comment thread bsp/esp-box-3/esp-box-3.c Outdated
Comment thread bsp/esp-box-3/esp-box-3.c Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2026

Test Results

28 tests   28 ✅  1m 18s ⏱️
 5 suites   0 💤
 5 files     0 ❌

Results for commit 627ce5c.

♻️ This comment has been updated with latest results.

@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch from fb405a8 to e3fc3ae Compare February 2, 2026 09:34
Comment thread components/icm42670/icm42670.c Outdated
Comment thread components/sensors/icm42670/icm42670.c
Comment thread components/sensors/aht30/aht30.c
@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch from e3fc3ae to a8808a5 Compare February 2, 2026 10:08
Comment thread components/sensors/icm42670/icm42670.c
Comment thread components/sensors/aht30/aht30.c
@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch 2 times, most recently from a0723b9 to 589c657 Compare February 2, 2026 10:56
Comment thread components/sensors/aht30/aht30.c
Comment thread bsp/esp-box-3/esp-box-3.c
Comment thread components/sensors/icm42670/icm42670.c
Copy link
Copy Markdown
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made first fast round and left some comments.
-Do we really need public API for sensors?

  • For example icm42670 doesn't need anything in header file. Same for aht30
  • Can we move icm42670 into sensor/ too?
  • We should add aht30 into upload_component.yml

Comment thread bsp/esp-box-3/esp-box-3.c Outdated
Comment thread bsp/esp-box-3/esp-box-3.c Outdated
Comment thread bsp/esp-box-3/include/bsp/esp-box-3.h
Comment thread bsp/esp-box-3/README.md Outdated
Comment thread examples/sensors/main/main.c Outdated
Comment thread examples/sensors/main/main.c Outdated
Comment thread examples/sensors/README.md Outdated
Comment thread examples/sensors/main/idf_component.yml
Comment thread examples/sensors/sdkconfig.bsp.esp-box-3
@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch from 589c657 to 4a0dae5 Compare February 2, 2026 14:05
@PetrESP
Copy link
Copy Markdown
Collaborator Author

PetrESP commented Feb 3, 2026

I made first fast round and left some comments. -Do we really need public API for sensors?

* For example `icm42670` doesn't need anything in header file. Same for `aht30`

I think that we should have public API for these sensors because they are also components all by themselves and that way we eliminate the need to use them with the sensor hub (which we use at the moment but we might switch to something else in the future).

* Can we move `icm42670` into sensor/ too?

Yeah, done.

* We should add `aht30` into `upload_component.yml`

Good point. Done.

Comment thread components/sensors/aht30/aht30.c
Comment thread bsp/esp-box-3/idf_component.yml Outdated
Comment thread bsp/esp-box-3/esp-box-3.c
@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch 4 times, most recently from ebddeca to 39b546a Compare February 3, 2026 15:11
@PetrESP
Copy link
Copy Markdown
Collaborator Author

PetrESP commented Feb 3, 2026

cursor review

@cursor
Copy link
Copy Markdown

cursor Bot commented Feb 3, 2026

Skipping Bugbot: Bugbot is globally disabled for this team

@PetrESP PetrESP requested a review from espzav February 3, 2026 15:53
@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch 6 times, most recently from cbeaddd to ab4c5c7 Compare February 5, 2026 15:33
Copy link
Copy Markdown
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrESP Thank you, great work! I left some comments yet.

Comment thread .github/ci/update_supported_boards.py Outdated
Comment thread bsp/esp-box-3/include/bsp/esp-box-3.h Outdated
Comment thread docu/doxyfiles/templates/how_to_use/g10_sensors.md
Comment thread docu/doxyfiles/templates/how_to_use/g10_sensors.md Outdated
Comment thread bsp/esp-box-3/esp-box-3.c Outdated
Comment thread components/sensors/aht30/include/aht30.h Outdated
Comment thread components/sensors/aht30/aht30.c Outdated
Comment thread components/sensors/aht30/aht30.c Outdated
Comment thread components/sensors/aht30/README.md Outdated
Comment thread components/sensors/aht30/CMakeLists.txt
@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch from ab4c5c7 to 8092986 Compare February 6, 2026 15:07
Copy link
Copy Markdown
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrESP Thank you for the great work! LGTM

@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch from 8092986 to 603cdce Compare February 11, 2026 09:18
Comment thread components/sensors/aht30/aht30.c
@PetrESP
Copy link
Copy Markdown
Collaborator Author

PetrESP commented Feb 11, 2026

cursor review

Comment thread components/sensors/aht30/include/aht30.h Outdated
Comment thread components/sensors/aht30/aht30.c
@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch 2 times, most recently from a68213f to e64e6f0 Compare February 11, 2026 09:54
Comment thread components/sensors/aht30/aht30.c
@PetrESP PetrESP force-pushed the feat/ICM42607_sensor_hub_api branch from e64e6f0 to 627ce5c Compare February 17, 2026 09:13
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread components/sensors/aht30/aht30.c
@github-actions
Copy link
Copy Markdown

⚠️ Build failure was ignored (continue-on-error enabled).

See details: View build logs

@PetrESP PetrESP merged commit acc2fdf into master Feb 17, 2026
97 checks passed
@PetrESP PetrESP deleted the feat/ICM42607_sensor_hub_api branch February 17, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants