Skip to content

Bsp/esp32s31 korvo1#789

Draft
espzav wants to merge 2 commits into
masterfrom
bsp/esp32s31_korvo1
Draft

Bsp/esp32s31 korvo1#789
espzav wants to merge 2 commits into
masterfrom
bsp/esp32s31_korvo1

Conversation

@espzav
Copy link
Copy Markdown
Collaborator

@espzav espzav commented May 28, 2026

Checklist for new Board Support package or Component

Change description

  • New BSP added
  • Updated display_audio_photo example - changed default sample rate and added another test wav file
  • Updated display_camera_video example - Added PPA to requires

Issues

  • Audio working only with 16000 Hz sample rate (not using MCLK - not working with MCLK)
    • Confirmed by audio team - MCLK is unconnected on this board and there is some clock issue and there is recommended to use 16kHz sample rate - added to Readme
  • Camera with esp_video version 2.2.0 is working but there is compilation issue - waiting for fix
    • Fixed, but not released (issue is only on latest master)
  • button component cannot be initialized (needs (ADC_ATTEN_DB_6 + 1))

@espzav espzav force-pushed the bsp/esp32s31_korvo1 branch 4 times, most recently from a000658 to de173de Compare June 1, 2026 12:55
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

⚠️ Build failure was ignored (continue-on-error enabled).

See details: View build logs

@espzav espzav force-pushed the bsp/esp32s31_korvo1 branch from de173de to 8adc207 Compare June 2, 2026 08:22
Copy link
Copy Markdown
Collaborator

@PetrESP PetrESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed I did a pre-review of the changes. I can see that basically everything was generated so I didn't perform a deep review.

Comment thread bsp/esp32_s31_korvo_1/include/bsp/touch.h
Comment thread bsp/esp32_s31_korvo_1/src/led_blink_defaults.c
Comment thread examples/display_sdcard/main/example_display.c Outdated
Comment thread examples/display_audio_photo/main/app_disp_fs.c Outdated
Comment thread bsp/esp32_s31_korvo_1/Kconfig Outdated
@PetrESP
Copy link
Copy Markdown
Collaborator

PetrESP commented Jun 2, 2026

I am getting this error when playing music in the display_audio_photo example

E (828099) i2s_common: i2s_channel_disable(1345): the channel has not been enabled yet

@PetrESP
Copy link
Copy Markdown
Collaborator

PetrESP commented Jun 2, 2026

Can we add S31 to the benchmark example?

@espzav espzav force-pushed the bsp/esp32s31_korvo1 branch from 8adc207 to 6ac90df Compare June 2, 2026 14:14
@espzav
Copy link
Copy Markdown
Collaborator Author

espzav commented Jun 2, 2026

@PetrESP Thank you for review. I fixed some issues and added benchmark example - we need to add the board to BSP Wall too - next week :-)

@espzav espzav force-pushed the bsp/esp32s31_korvo1 branch from 6ac90df to 8d3a2bc Compare June 3, 2026 12:49
@espzav espzav force-pushed the bsp/esp32s31_korvo1 branch from 8d3a2bc to 0534dee Compare June 3, 2026 12:51
@espzav espzav force-pushed the bsp/esp32s31_korvo1 branch from 0534dee to 2cb7904 Compare June 3, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants