Bsp/esp32s31 korvo1#789
Draft
espzav wants to merge 2 commits into
Draft
Conversation
a000658 to
de173de
Compare
|
de173de to
8adc207
Compare
PetrESP
reviewed
Jun 2, 2026
Collaborator
PetrESP
left a comment
There was a problem hiding this comment.
As discussed I did a pre-review of the changes. I can see that basically everything was generated so I didn't perform a deep review.
Collaborator
|
I am getting this error when playing music in the |
Collaborator
|
Can we add S31 to the benchmark example? |
8adc207 to
6ac90df
Compare
Collaborator
Author
|
@PetrESP Thank you for review. I fixed some issues and added benchmark example - we need to add the board to BSP Wall too - next week :-) |
6ac90df to
8d3a2bc
Compare
8d3a2bc to
0534dee
Compare
0534dee to
2cb7904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for new Board Support package or Component
urlfield defined and overridden paths for local componentsChange description
display_audio_photoexample - changed default sample rate and added another test wav filedisplay_camera_videoexample - Added PPA to requiresIssues
esp_videoversion2.2.0is working but there is compilation issue - waiting for fix(ADC_ATTEN_DB_6 + 1))