-
Notifications
You must be signed in to change notification settings - Fork 96
Add iFFT function (DSP-160) #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
any suggestions on API before I move forward? |
Hi @howard0su , Contra: But, from another side, yes, I think, that we can add this parameter as a default one. Please, let me think up to tomorrow.... And, thank you for your work! |
decision? |
Hi @howard0su What do you think about this? Dmitry |
So the consumer still have to normalize the result by divide N? I am open for options, but just want to make sure we think through the pros and cons. |
@howard0su It's better to add just additional iFFT function to normalize the result. |
I didn't find a good way to apply 1/N to the table. It doesn't work if you just scale the table by N during initialization. Regarding additional iFFT function, yes, we can easily add one additional function, or we can put it into the logic of dsps_bit_rev_fc32_ansi |
Hi @howard0su |
Description
Add reverse FFT support.
[Only fc32 as a PR to discuss]
Generate a reverse twiddle table when init. No need to change other logic as FFT. finally rescale the result by 1/N.
Need discussion on API design
Related
Fix #62
Testing
Add a simple test case to test
Checklist
Before submitting a Pull Request, please ensure the following: