Skip to content

Conversation

@radimkarnis
Copy link
Member

@radimkarnis radimkarnis commented Dec 16, 2025

@radimkarnis radimkarnis requested a review from Copilot December 16, 2025 11:42
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello radimkarnis, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4114166

@radimkarnis radimkarnis changed the title feat(usb-otg): Add support for USB-OTG RX/TX feat(USB-OTG): Add support for USB-OTG RX/TX Dec 16, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds USB-OTG transport layer support for ESP32-S2/S3/P4 chips, enabling data transmission and reception through the USB-OTG interface as an alternative to UART and USB Serial JTAG.

  • Adds USB-OTG initialization with interrupt handling for RX/TX operations
  • Updates transport initialization to prioritize USB-OTG when active
  • Updates esp-stub-lib submodule to include USB-OTG API support

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/transport.c Adds USB-OTG transport initialization with priority over USB Serial JTAG
esp-stub-lib Updates submodule reference to version with USB-OTG support

Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Dzarda7 Dzarda7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@radimkarnis radimkarnis merged commit 2fa753f into master Dec 19, 2025
7 checks passed
@radimkarnis radimkarnis deleted the feat/usb_otg branch December 19, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants