Skip to content

Conversation

@mdwn
Copy link

@mdwn mdwn commented Jan 10, 2026

Description

The error messages for vPortEnterCritical and vPortExitCritical are misleading when they're called on a multi-core target, as they seem to imply that the call is NOT supported on a single-core target. In fact, they are, these functions are, however, not supported on multi-core targets, so the error message has been updated to reflect this.

Related

None

Testing

None, this is just a string change.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Note

Updates misleading runtime error strings under #if (configNUM_CORES > 1) in components/freertos/FreeRTOS-Kernel/portable/riscv/port.c.

  • Corrects messages in vPortEnterCritical and vPortExitCritical to state they are not supported on multi-core targets and to use vPortEnterCriticalMultiCore(portMUX_TYPE *mux) / vPortExitCriticalMultiCore(portMUX_TYPE *mux) instead

Written by Cursor Bugbot for commit bc8c736. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 10, 2026

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello mdwn, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against bc8c736

@github-actions github-actions bot changed the title Correct misleading error messages for vPortEnter/ExitCritical. Correct misleading error messages for vPortEnter/ExitCritical. (IDFGH-17077) Jan 10, 2026
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 10, 2026
…ritical

The error messages for vPortEnterCritical and vPortExitCritical are
misleading when they're called on a multi-core target, as they seem to
imply that the call is NOT supported on a single-core target. In fact,
they are, these functions are, however, not supported on multi-core
targets, so the error message has been updated to reflect this.
@mdwn mdwn force-pushed the fix-multicore-error-messages branch from 3a28e63 to bc8c736 Compare January 10, 2026 18:37
@mdwn mdwn changed the title Correct misleading error messages for vPortEnter/ExitCritical. (IDFGH-17077) fix(freertos): Correct misleading error messages for vPortEnter/ExitCritical (IDFGH-17077) Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants