fix(freertos): Correct misleading error messages for vPortEnter/ExitCritical (IDFGH-17077) #18109
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error messages for vPortEnterCritical and vPortExitCritical are misleading when they're called on a multi-core target, as they seem to imply that the call is NOT supported on a single-core target. In fact, they are, these functions are, however, not supported on multi-core targets, so the error message has been updated to reflect this.
Related
None
Testing
None, this is just a string change.
Checklist
Before submitting a Pull Request, please ensure the following:
Note
Updates misleading runtime error strings under
#if (configNUM_CORES > 1)incomponents/freertos/FreeRTOS-Kernel/portable/riscv/port.c.vPortEnterCriticalandvPortExitCriticalto state they are not supported on multi-core targets and to usevPortEnterCriticalMultiCore(portMUX_TYPE *mux)/vPortExitCriticalMultiCore(portMUX_TYPE *mux)insteadWritten by Cursor Bugbot for commit bc8c736. This will update automatically on new commits. Configure here.