Add support for non-WiFi networks #54
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check if connected to non-WiFi (i.e. ethernet and thread) networks - New menuconfig option to be selected when using thread - Has not yet been tested
vikramdattu
reviewed
Jan 27, 2025
| list(APPEND priv_req esp_wifi) | ||
| endif() | ||
|
|
||
| if(CONFIG_ESP_INSIGHTS_THREAD_ENABLED) |
Contributor
There was a problem hiding this comment.
We should not create on the new config for thread enabled. We can use the global one.
| bool wifi_connected = is_wifi_connected(); | ||
| bool ethernet_connected = is_ethernet_connected(); | ||
| bool is_thread_with_br = is_thread_with_br_connected(); | ||
|
|
Contributor
There was a problem hiding this comment.
Just to be more clear, let's add new variable named, bool is_connected_to_internet = wifi_connected || ethernet_connected || is_thread_with_br;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Insights currently only works on WiFi for sending data, this PR adds checks for ethernet and Thread networks to allow data to be transmitted over them too.
Changes include:-
is_insights_active, if any one is active then return trueRelated
Fixes #51
Testing
This hasn't yet been properly tested.
Checklist
Before submitting a Pull Request, please ensure the following: