Skip to content

fix(button): handle GPIO ISR service installation idempotency #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iyassou wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(button): handle GPIO ISR service installation idempotency #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/button/button_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ static esp_err_t button_gpio_set_intr(int gpio_num, gpio_int_type_t intr_type, g
ESP_RETURN_ON_FALSE(ret == ESP_OK, ret, TAG, "Set gpio interrupt type failed");
if (!isr_service_installed) {
ret = gpio_install_isr_service(ESP_INTR_FLAG_IRAM);
ESP_RETURN_ON_FALSE(ret == ESP_OK, ret, TAG, "Install gpio interrupt service failed");
// ESP_ERR_INVALID_STATE = service previously installed by another component (idempotent)
ESP_RETURN_ON_FALSE((ret == ESP_OK) || (ret == ESP_ERR_INVALID_STATE), ret, TAG, "Install gpio interrupt service failed");
isr_service_installed = true;
}
ret = gpio_isr_handler_add(gpio_num, isr_handler, (void *)gpio_num);
Expand Down