Create user callback on command to allow monitoring in bridge (CON-890) #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
wqx6
reviewed
Nov 23, 2023
wqx6
reviewed
Nov 23, 2023
| @@ -0,0 +1,13 @@ | |||
| --- components/esp_matter/esp_matter_command.cpp | |||
Contributor
Author
|
I updated to add secondary TLVReader |
Collaborator
|
This was rebased internally and merged. See here: be12e6a Closing this. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a callback hook to allow a bridge to monitor commands. Does not replace the command, it is an additional monitoring hook to allow inspection of the command parameters.
This is very similar to #35 except this callback is for monitoring and does not stop the existing callback from running. In pull 35 he wanted to replace the callback. I initially started off replacing the callback as described in #704 but then I figured out that I wanted to monitor the command, not replace it. In my case I need to keep the underlying function and then I add on additional operations via the user_cb. PR35 can easily be implemented by adding a set function for the main callback.