fix(mdns): put srv/txt records in additional section for ptr queries #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
approved these changes
May 28, 2025
There was a problem hiding this comment.
Thanks for posting this fix! the change LGTM.
Sorry for such a slow review, I wanted to accept this change after the refactor (in #776), but I think we can merge this first and then forward-port the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enforces a requirement in RFC 6763 Section 12.1 regarding SRV and TXT records in response to PTR queries: such records should be placed in the additional section and not answer section.
Testing
This change is necessary to pass Thread certification test cases related to mDNS discovery of v1.3/v1.4 TXT records.
Checklist
Before submitting a Pull Request, please ensure the following: