[mosq]: Add support for linux build #977
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
force-pushed
the
feat/mosq_linux_build
branch
from
a52c046 to
9186c99
Compare
david-cermak
force-pushed
the
feat/mosq_linux_build
branch
3 times, most recently
from
a7b46e1 to
d11a9dc
Compare
In order to support linux builds, we define this component as a no-op
david-cermak
force-pushed
the
feat/mosq_linux_build
branch
from
d11a9dc to
d7ed8a8
Compare
euripedesrocha
approved these changes
Dec 18, 2025
| rules: | ||
| - if: idf_version >=6.0 | ||
| version: ^1.0.0 | ||
| espressif/sock_utils: |
Collaborator
There was a problem hiding this comment.
Should we guard to not add it on Linux target build?
Collaborator
Author
There was a problem hiding this comment.
wanted to keep this cleaner, but i'll probably make sense in future when component manager becomes more stable and dependency resolution more predictable.
just didn't want to end-up like our Ethernet component: https://github.com/espressif/esp-eth-drivers/blob/master/ethernet_init/idf_component.yml 😄
|
|
||
| include($ENV{IDF_PATH}/tools/cmake/project.cmake) | ||
|
|
||
| if("${IDF_TARGET}" STREQUAL "linux") |
Collaborator
There was a problem hiding this comment.
Isn't cleaner to move this to component manager yml?
Collaborator
Author
There was a problem hiding this comment.
Yes, it's probably cleaner, but less practical.
Remember the issues Ondrej had with #ifdef-in components/version? Plus it'd add one more expansion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mosquito
sock_utils
Examples