-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Add basic flashing support #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello Dzarda7, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
@antmak @erhankur what do you guys say to something like this? It is just as simple as it can be for now, but necessary for us to move on. I read about future plans in #9, but not sure about final decision so I made this for us to have something working and later on we can move to BTW if you are okay with this, I am not sure to which functions add |
7176de8 to
07d539d
Compare
The plan is still the same, but I haven't had time to implement the flasher functionality on top of the esp_flash APIs. So please go ahead. |
|
Thanks, I can definitely help with esp_flash implementation, should be especially useful for 32-bit flashing which we also need. This is just to have something working for us now. |
dobairoland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have just some minor request regarding clarification.
This commit adds support for flashing for all targets. Support is only basic without 32-bit addressing using ROM functions including legacy ones.
07d539d to
4101650
Compare
|
@erhankur @dobairoland I believe I addressed all the issues, thank you very much for the check. If you agree, this is ready for merge. |
erhankur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM now.
This commit adds support for flashing for all targets. Support is only basic without 32-bit addressing using ROM functions including legacy ones.
Description
Related
Testing
Tested on a few targets - ESP32, ESP32-S3, ESP32-C6, not all for now, as no big issue is expected with this.
Checklist
Before submitting a Pull Request, please ensure the following: