Skip to content

Fix SWD, output couldn't be disabled in dedic_gpio (EUB-98) #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viric wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SWD, output couldn't be disabled in dedic_gpio (EUB-98) #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/debug_probe/debug_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ void debug_probe_init_swd_pins(void)
.gpio_array = bundle_io_gpios,
.array_size = ARRAY_SIZE(bundle_io_gpios),
.flags = {
.out_en = 1,
.out_en = 0, /* We will output without dedic_gpio, or we cannot disable output */
.in_en = 1,
},
};
Expand Down
8 changes: 4 additions & 4 deletions components/debug_probe/debug_gpio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,12 @@ void debug_probe_notify_activity(bool active);

__STATIC_FORCEINLINE void debug_probe_swdio_out_enable(void)
{
REG_WRITE(GPIO_FUNC0_OUT_SEL_CFG_REG + (GPIO_SWDIO * 4), dedic_gpio_conf);
gpio_ll_output_enable(dedic_gpio_dev, GPIO_SWDIO);
}

__STATIC_FORCEINLINE void debug_probe_swdio_out_disable(void)
{
REG_WRITE(GPIO_FUNC0_OUT_SEL_CFG_REG + (GPIO_SWDIO * 4), dedic_gpio_conf);
gpio_ll_output_disable(dedic_gpio_dev, GPIO_SWDIO);
}

Expand All @@ -129,17 +129,17 @@ __STATIC_FORCEINLINE void debug_probe_swclk_clr(void)

__STATIC_FORCEINLINE void debug_probe_swdio_set(void)
{
dedic_gpio_cpu_ll_write_mask(GPIO_SWDIO_OUT_MASK, GPIO_SWDIO_OUT_MASK);
gpio_ll_set_level(dedic_gpio_dev, GPIO_SWDIO, 1);
}

__STATIC_FORCEINLINE void debug_probe_swdio_clr(void)
{
dedic_gpio_cpu_ll_write_mask(GPIO_SWDIO_OUT_MASK, 0);
gpio_ll_set_level(dedic_gpio_dev, GPIO_SWDIO, 0);
}

__STATIC_FORCEINLINE void debug_probe_swdio_write(int val)
{
dedic_gpio_cpu_ll_write_mask(GPIO_SWDIO_OUT_MASK, (val & 0x01) ? GPIO_SWDIO_OUT_MASK : 0);
gpio_ll_set_level(dedic_gpio_dev, GPIO_SWDIO, (val & 0x1)?1:0);
}

__STATIC_FORCEINLINE void debug_probe_swd_blink(int on)
Expand Down