-
Notifications
You must be signed in to change notification settings - Fork 37
feat(usb_host): Exit suspend state by port reset #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bc85ce3 to
b17b80c
Compare
b17b80c to
1213c78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 20
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
ef89423 to
9774d1b
Compare
tore-espressif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Exiting suspended root port through host initiated reset
9774d1b to
e48b3d4
Compare
Description
According to the programming guide, there are several ways how to exit suspended state:
usb_host_lib_root_port_resume()Exiting Suspend Through Host Initiated Reset
When the port is in suspended state, it must react to
HCD_PORT_CMD_RESETcommand, which will effectively resume the root port after the reset sequence.This change does not bring any benefits right now, adding it just for the sake of the completeness of the global suspend/resume feature.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following:
Note
Enable host-initiated reset while port is suspended to exit suspend; add ping helper and tests, including a new suspend+reset test.
HCD_PORT_CMD_RESETwhen port isHCD_PORT_STATE_SUSPENDEDin_port_cmd_reset()(host/usb/src/hcd_dwc.c).TRANSFER_MAX_BYTESandtest_hcd_ping_device()helper to probe device responsiveness (host/usb/test/target_test/common/hcd_common.{c,h}).test_hcd_ping_device(), manage URB lifecycle, and validate states (host/usb/test/target_test/hcd/main/test_hcd_port.c).test_hcd_port.c).Written by Cursor Bugbot for commit e48b3d4. This will update automatically on new commits. Configure here.