add s3 h2 support for USB_RAM_BLOCK - #259
Open
brianignacio5 wants to merge 1 commit into
Open
Conversation
|
Download the artifacts for this pull request: |
Closed
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #255
This pull request introduces improved detection and handling of Espressif USB-Serial/JTAG and USB-OTG interfaces, with changes to both the core loader logic and chip-specific ROM classes. The main goal is to better distinguish between connection types (USB-Serial/JTAG vs. USB-OTG), adapt flash write sizes accordingly, and expose relevant USB identifiers for external use.
USB Interface Detection and Handling:
usesUsbJtagSerial()andusesUsbOtg()methods toESPLoaderto reliably detect if the connection uses Espressif USB-Serial/JTAG or USB-OTG, using both USB VID/PID and chip-specific helpers for fallback.runStub()), the loader now applies a USB-specific flash write size limit if USB-OTG is detected, matching esptool.py's buffer limits. [1] [2]ROMbase class and specific chip classes (ESP32S3ROM,ESP32H2ROM) now include helper methods (usesUsbJtagSerial,usesUsbOtg,usingUsbOtg) for fallback detection via hardware registers. [1] [2] [3] [4]USB VID/PID Constants and Transport Enhancements:
ESPRESSIF_VID) and USB-Serial/JTAG product ID (USB_JTAG_SERIAL_PID) for use throughout the codebase and by consumers. [1] [2] [3] [4]getVid()method to theTransportclass to retrieve the USB vendor ID from the connected device.These changes make USB connection type detection more robust and allow the loader to optimize behavior based on the actual hardware interface in use.
Related
Replace #257 with an approach closer to esptool.py
Testing
Checklist
Before submitting a Pull Request, please ensure the following: