Skip to content

Commit 6e2de1e

Browse files
authored
fix: moving updateProjectBuildFolder to Config provider (#1447)
1 parent 6a67e13 commit 6e2de1e

2 files changed

Lines changed: 3 additions & 12 deletions

File tree

bundles/com.espressif.idf.launch.serial.core/src/com/espressif/idf/launch/serial/core/IDFCoreLaunchConfigProvider.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import org.eclipse.launchbar.core.target.ILaunchTarget;
1616

1717
import com.espressif.idf.core.build.IDFLaunchConstants;
18+
import com.espressif.idf.core.util.IDFUtil;
1819
import com.espressif.idf.core.util.LaunchUtil;
1920

2021
public class IDFCoreLaunchConfigProvider extends CoreBuildGenericLaunchConfigProvider
@@ -77,7 +78,8 @@ public boolean launchConfigurationAdded(ILaunchConfiguration configuration) thro
7778
@Override
7879
public boolean launchConfigurationChanged(ILaunchConfiguration configuration) throws CoreException
7980
{
80-
// nothing to do
81+
IDFUtil.updateProjectBuildFolder(configuration.getWorkingCopy());
82+
8183
return false;
8284
}
8385

bundles/com.espressif.idf.launch.serial.ui/src/com/espressif/idf/launch/serial/ui/internal/SerialFlashLaunchConfigTabGroup.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,29 +18,18 @@
1818
import org.eclipse.core.resources.IResource;
1919
import org.eclipse.core.runtime.CoreException;
2020
import org.eclipse.debug.core.ILaunchConfiguration;
21-
import org.eclipse.debug.core.ILaunchConfigurationWorkingCopy;
2221
import org.eclipse.debug.ui.AbstractLaunchConfigurationTabGroup;
2322
import org.eclipse.debug.ui.ILaunchConfigurationDialog;
2423

2524
import com.espressif.idf.core.logging.Logger;
26-
import com.espressif.idf.core.util.IDFUtil;
2725

2826
public class SerialFlashLaunchConfigTabGroup extends AbstractLaunchConfigurationTabGroup
2927
{
3028

3129
@Override
3230
public void createTabs(ILaunchConfigurationDialog dialog, String mode)
3331
{
34-
3532
setTabs();
36-
37-
}
38-
39-
@Override
40-
public void performApply(ILaunchConfigurationWorkingCopy configuration)
41-
{
42-
super.performApply(configuration);
43-
IDFUtil.updateProjectBuildFolder(configuration);
4433
}
4534

4635
@Override

0 commit comments

Comments
 (0)