Skip to content

Conversation

@sigmaaa
Copy link
Collaborator

@sigmaaa sigmaaa commented Sep 21, 2025

Description

This should make the process of updating the Espressif IDE smoother and will not negatively affect the user experience
Fixes # (IEP-1636

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Go to Help -> Install New Tools -> Manage -> check if eclipse product latest update site is enabled

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • update site

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • New Features

    • Enabled the Eclipse Releases repository by default, giving users immediate access to a broad set of plugins and updates without manual setup.
  • Chores

    • Updated default update sources to enable Eclipse Releases; no other repositories or configuration settings were changed.

@coderabbitai
Copy link

coderabbitai bot commented Sep 21, 2025

Walkthrough

Enables the Eclipse “releases/latest” repository by default in the product configuration by changing its enabled flag from false to true. No other repositories or configuration entries are altered.

Changes

Cohort / File(s) Summary of Changes
Product configuration
releng/com.espressif.idf.product/idf.product
Set repository http://download.eclipse.org/releases/latest/ enabled="true" (was "false"); no other entries modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • AndriiFilippov
  • alirana01
  • kolipakakondal

Poem

I flipped a tiny switch—hop!—now updates flow,
From Eclipse’s latest burrow, fresh bits glow.
Ears up, paws tap, dependencies align,
One nibble of config—everything’s fine.
(°·ᴗ·°)/ carrot-commit, ship in time!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately summarizes the primary change: enabling the Eclipse product update site in the Espressif IDE (IEP-1636). It is a concise, single sentence that clearly relates to the changeset and will be understandable to reviewers scanning history.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch IEP-1636

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
releng/com.espressif.idf.product/idf.product (1)

96-96: Give the repo a friendly name for UI clarity.

Empty name renders poorly in “Manage”/p2 dialogs.

-      <repository location="https://download.eclipse.org/releases/latest/" name="" enabled="true" />
+      <repository location="https://download.eclipse.org/releases/latest/" name="Eclipse Releases" enabled="true" />
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47ca2ad and 8350a7a.

📒 Files selected for processing (1)
  • releng/com.espressif.idf.product/idf.product (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build_macos
  • GitHub Check: build
  • GitHub Check: build_windows
🔇 Additional comments (1)
releng/com.espressif.idf.product/idf.product (1)

96-96: Verify target-platform compatibility and update behavior across OSes.

releng/com.espressif.idf.product/idf.product currently enables http://download.eclipse.org/releases/latest/ (repositories block — lines ~95–97); the target file pins https://download.eclipse.org/releases/2025-03/ (releng/com.espressif.idf.target/com.espressif.idf.target.target). Manifests also pin CDT bundles (e.g., bundles/com.espressif.idf.ui/META-INF/MANIFEST.MF: org.eclipse.cdt.core;bundle-version="9.0.0").

  • If enabling releases/latest is unintended: disable it or replace with a pinned release URL in releng/com.espressif.idf.product/idf.product.
  • If intentional: validate p2 update prompt / auto-update behavior on Windows, Linux and macOS to ensure Platform/CDT will not be upgraded beyond tested versions (check restart/privilege flows).
  • Cross-check product features vs target definition and bundle-version pins (releng/com.espressif.idf.target/... and bundles/*/META-INF/MANIFEST.MF) before release.

<repositories>
<repository location="https://dl.espressif.com/dl/idf-eclipse-plugin/updates/beta/" name="" enabled="false" />
<repository location="http://download.eclipse.org/releases/latest/" name="" enabled="false" />
<repository location="http://download.eclipse.org/releases/latest/" name="" enabled="true" />

This comment was marked as spam.

@AndriiFilippov
Copy link
Collaborator

AndriiFilippov commented Sep 25, 2025

@sigmaaa hi!

Tested under:
OS - Windows 11 / Linux Ubuntu

eclipse product latest update site enabled ✔️
LGTM 👍

@alirana01 @kolipakakondal please, review

@kolipakakondal
Copy link
Collaborator

The only problem could be that as soon as Eclipse pushes an update to a newer version, Espressif-IDE will prompt you to update. However, we are not sure whether our plugins are compatible with the latest version or not

@kolipakakondal
Copy link
Collaborator

Another thing could be that it will prompt you with too many irrelevant updates, which may confuse the user. Obviously, the user don't want install all of them which are not required to run the espressif-ide, we can see if we can solve the same problem with a selective approach.

Screenshot 2025-09-29 at 1 25 13 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants