Skip to content

GH issue: Abort build process in presence of errors (IEP-1180) #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolipakakondal merged 1 commit into from
Mar 27, 2024
Merged

GH issue: Abort build process in presence of errors (IEP-1180) #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/IDFBuildConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ private void runCmakeBuildCommand(IConsole console, IProgressMonitor monitor, IP

Instant finish = Instant.now();
long timeElapsed = Duration.between(start, finish).toMillis();
if (!monitor.isCanceled())
if (!monitor.isCanceled() && epm.getErrorCount() == 0)
{
project.refreshLocal(IResource.DEPTH_INFINITE, monitor);
Comment on lines +454 to 456
Copy link
Copy Markdown
Collaborator

@alirana01 alirana01 Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sigmaaa is it going to be fine in terms that the indexer may not be triggered if the project is not refreshed or it will be triggered in both cases?

Copy link
Copy Markdown
Collaborator Author

@sigmaaa sigmaaa Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alirana01,

The project will be refreshed during indexing anyway if I remember correctly.

ParitionSizeHandler paritionSizeHandler = new ParitionSizeHandler(project, infoStream, console);
Expand Down