IEP-1194: No such file exceptions in error log during IDE startup

[sigmaaa]

Description

During the first IDE startup, we are trying to initialize toolchains from the PATH. If Path contains paths that don't exist anymore we will get an exception

Fixes # (IEP-1194

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How has this been tested?

• Create new workspace
• add non-existent path to PATH
• clear error log
• restart IDE
• verify that no "No such file" exceptions in error log after restart

Test Configuration:

• ESP-IDF Version:
• OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

• Component 1
• Component 2

Checklist

• PR Self Reviewed
• Applied Code formatting
• Added Documentation
• Added Unit Test
• Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

• Bug Fixes
  • Improved the toolchain manager to only include existing directories, enhancing reliability.

[coderabbitai]

Walkthrough

This update to the ESPToolChainManager.java enhances the toolchain management within the Eclipse plugin for ESP-IDF by ensuring that the getDirectories method now intelligently filters out and omits any non-existent paths from its output. This refinement aims to streamline the build process by avoiding potential errors related to invalid directory paths.

Changes

File Path	Change Summary
.../idf/core/toolchain/ESPToolChainManager.java	Updated getDirectories to exclude non-existent paths from results

Possibly related issues

• getting 13 semantic error while building "Hello World" in idf-eclipse plugin in ubuntu. (IEP-970) #777: The changes could indirectly support Objective 2 by ensuring cleaner project setup, potentially reducing semantic errors related to the toolchain setup. The direct link is tenuous, but better path management could lead to fewer configuration issues.

Poem

In a burrow, deep and wide,
A coderabbit does reside.
With a hop, skip, and a leap,
Cleaned the paths, no longer steep.
🌟 "No more errors," it declared,
"For your builds, I've greatly cared!"
🐰💻✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e1bf806 and 64a1196.

Files selected for processing (1)

• bundles/com.espressif.idf.core/src/com/espressif/idf/core/toolchain/ESPToolChainManager.java (2 hunks)

Files not reviewed due to errors (1)

• ESPToolChainManager.java (no review received)

[sigmaaa]

Self reviewed

[AndriiFilippov]

@sigmaaa hi !

Tested under:

OS - Windows 10
ESP-IDF: v5.2

Nice ! We have gotten rid of unnecessary clutter in the console.
Before, when launching the IDE, I have almost had a heart attack from the amount of this red spam.

Before:

Your PR:

LGTM 👍

[kolipakakondal]

LGTM