(WIP): python sanity check improvements

[alirana01]

Description

Related

Testing

---

Checklist

Before submitting a Pull Request, please ensure the following:

• 🚨 This PR does not introduce breaking changes.
• All CI checks (GH Actions) pass.
• Documentation is updated as needed.
• Tests are updated or added as necessary.
• Code is well-commented, especially in complex areas.
• Git history is clean — commits are squashed to the minimum necessary.

[gemini-code-assist]

Summary of Changes

Hello @alirana01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the application's Python environment validation process. By transitioning from basic pass/fail indicators to a comprehensive, structured breakdown of each check, it provides users with much clearer insights into potential Python-related issues. This enhancement is crucial for improving the user experience during setup and troubleshooting, as it pinpoints exactly where the Python environment might be misconfigured, both in the command-line and graphical interfaces.

Highlights

• Structured Python Sanity Check Results: The Python sanity check mechanism has been refactored to return a structured PythonSanityCheckResponse object, providing detailed information for each individual check (e.g., version, pip, venv, standard library, ctypes, SSL/HTTPS support) rather than a simple boolean or generic error.
• Enhanced User Interface for Python Checks: The GUI components (PythonSanitycheck.vue and SimpleSetup.vue) have been updated to parse and display these detailed check results, offering users a clear, itemized list of what passed or failed, along with specific messages for troubleshooting.
• Improved Localization for Error Messages: New localization keys have been added for both English and Chinese to support the granular error reporting, allowing for more precise user guidance when Python sanity checks fail.
• Code Refactoring for Maintainability: The python_sanity_check logic in idf_im_lib::python_utils.rs has been broken down into smaller, dedicated helper functions (check_python_version, check_python_module, check_python_script) to improve code organization and readability.
• Gitignore Update: The .gitignore file now includes an entry to ignore the .cursor/ directory, preventing IDE-specific configuration files from being committed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• .gitignore
  • Added .cursor/ to the ignore list.
• src-tauri/locales/app.yml
  • Added new localization keys (gui.system_dependencies.python_check_failed_label, python.sanitycheck.failed.summary) for detailed Python sanity check failure messages.
• src-tauri/src/cli/prompts.rs
  • Updated python_sanity_check to consume the new PythonSanityCheckResponse and print detailed results to the console.
• src-tauri/src/gui/commands/installation.rs
  • Modified calls to python_sanity_check to correctly access the all_passed field from the new structured response.
• src-tauri/src/gui/commands/prequisites.rs
  • Updated the python_sanity_check Tauri command to return the new PythonSanityCheckResponse and log detailed warnings for failed checks.
• src-tauri/src/lib/python_utils.rs
  • Introduced PythonCheckResult and PythonSanityCheckResponse structs for structured output.
  • Refactored the main python_sanity_check function into modular helper functions (check_python_version, check_python_module, check_python_script).
  • Changed the return type of python_sanity_check to PythonSanityCheckResponse.
  • Added a temporary line to force the last check to fail for GUI testing purposes.
• src/components/SimpleSetup.vue
  • Updated the component to handle the new structured python_sanity_check response, extracting all_passed and displaying detailed error messages for failed checks.
• src/components/wizard_steps/PythonSanitycheck.vue
  • Refactored the component to display a list of individual Python sanity check results (pass/fail status, label, and message) in the UI.
  • Removed the old 'Manual Installation Required' section in favor of the new detailed list.
  • Updated the check_python_sanity method to process the new structured response.
  • Added new CSS for styling the check results display.
• src/locales/cn.json
  • Removed old manualInstall localization keys.
  • Added new failed.summary and failed.message localization keys for detailed Python sanity check results.
• src/locales/en.json
  • Removed old manualInstall localization keys.
  • Added new failed.summary and failed.message localization keys for detailed Python sanity check results.

Activity

• This pull request is currently marked as a Work In Progress (WIP), indicating it is still under active development or early review.
• The description includes standard pull request template placeholders, suggesting it's in the initial stages of being prepared for a full review.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request significantly improves the Python sanity check functionality by refactoring the backend to return a structured response. This allows for more detailed feedback in both the CLI and the GUI, which is a great improvement for the user experience. The code changes are well-structured, breaking down a large function into smaller, more maintainable pieces.

However, there is a critical piece of temporary code for testing purposes that must be removed before this can be merged, as it will always cause the sanity check to fail.

[gemini-code-assist]

This appears to be temporary code for testing the GUI, as it forces the last sanity check to always fail. This will prevent users from successfully passing the Python sanity check and must be removed before merging.