-
Notifications
You must be signed in to change notification settings - Fork 4
EIM-89: eim select added for the activation script #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @alirana01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
36ee489 to
c3a8a55
Compare
| # Sync selection with eim_idf.json for IDEs (silent on failure) | ||
| if ($_EimBinPath) { | ||
| try { | ||
| & $_EimBinPath select "{{idf_version}}" 2>$null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am almost sure the syntax 2>$null was introduced in PS5 (or was buggy before and was fixed in v5) and may not work on PS4. Could you please verify?
But as it's inside a try-catch block, this should not be a real issue, just a nitpick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$null is part of Powershell since v1.0 and since v3.0 you can basically redirect error stream using this
| ) | ||
|
|
||
| # Capture absolute eim path early (before PATH changes) | ||
| $_EimBinPath = (Get-Command eim -ErrorAction SilentlyContinue).Source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no EIM is present, you are effectively calling null.Source, which will fail and probably not silently. Can you check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working fine I have verified it and -ErrorAction flag is supposed to skip this as it will simply return the PS variable $null.
Hahihula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! After clearing up my concerns, I am happy. ;-) Thanks for the update.
Description
Added the eim select in sourcing scripts. This should select the correct version for eim and not have issues as mentioned in Jira ticket EIM-89
This is supposed to work if the eim is in path and fail silently as well.
Testing
Run the activation script and verify that eim select runs
also make sure that eim is in path.
We need to verify this with eim not in Path to see that the sourcing works for activation script and no errors are shown we have to fail silently in case of errors for eim select
Checklist
Before submitting a Pull Request, please ensure the following: