Skip to content

Conversation

@brianignacio5
Copy link
Collaborator

Description

Try to update pre-commit to add codespell hook.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

No tests, This is run in CI

  • Expected behaviour:

  • Expected output:

How has this been tested?

Test by checking CI actions.

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@brianignacio5 brianignacio5 changed the title update precommit Add codespell update precommit Dec 9, 2025
@Shen7436
Copy link
Collaborator

Shen7436 commented Dec 9, 2025

Hi @brianignacio5 Thanks for helping implement codespell :) I left two comments, PTAL.

Also, I’m wondering about the scope of the pre-commit checks. Ideally, only the modified files in a specific PR (i.e., the files listed on the Files changed page) should be checked, rather than running checks on the whole repo every time a new PR is created.

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice addition!

@Shen7436
Copy link
Collaborator

Hi @brianignacio5 Thanks for your updates! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants