ESP32 (IDF4) Fix for SPI Setup errors issue #2601 #2603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you please edit the other ESP32 board files too? |
Member
|
Wow, thanks for all your work on this - it looks great! I'll copy the changes to other boards at this end after merging |
gfwilliams
added a commit
that referenced
this pull request
Jan 29, 2025
…SCLK line so it's detected properly
Member
|
Just done - I did notice that the naming of the SPI SCLK decl was wrong so it might not have auto-assigned - the naming of it as SPIx_SCK is annoying and not like everywhere else (where we use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See notes on the change and the testing carried out in #2601