feat: add constructors and equality traits to SnowflakeColumn types #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `new` method for SnowflakeColumn and SnowflakeColumnType - Implement PartialEq and Eq traits for both structs - Add comprehensive documentation with doctests and examples - Expand integration tests to validate column_types() with multiple data types - Test coverage includes fixed, text, boolean, date, and timestamp_ntz types
Reverts to the original test behavior that inserts two rows of data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances SnowflakeColumn and SnowflakeColumnType structs to make them easier to mock and test in user code. The primary goal is to improve the developer experience when writing tests that involve these column metadata structures.
Changes
new()constructors for both SnowflakeColumn and SnowflakeColumnTypeBenefits
Users can now easily create mock instances of these structs in their tests without relying on internal implementation details. The equality traits also enable straightforward assertions in test scenarios.