Add setFreezePanes, setFreezePanesTopCell #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamaroning
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Thank you for contributing @henrikekblad !
It looks overall good but there are a few small nits.
Also, could you run cargo fmt in the rust/ directory?
rust/src/wrapper/worksheet.rs
Outdated
Comment on lines
173
to
174
|
|
There was a problem hiding this comment.
Please remove empty lines
rust/src/wrapper/worksheet.rs
Outdated
Comment on lines
130
to
131
| /// # Examples | ||
| /// |
There was a problem hiding this comment.
I think examples of rust_xlsxwriter should be removed so that users don't get confused.
rust/src/wrapper/worksheet.rs
Outdated
Comment on lines
201
to
202
| /// # Examples | ||
| /// |
rust/src/wrapper/worksheet.rs
Outdated
|
|
||
| #[wasm_bindgen(js_name = "setFreezePanes", skip_jsdoc)] | ||
| pub fn set_freeze_panes(&self, row: xlsx::RowNum, col: xlsx::ColNum,) -> WasmResult<Worksheet> { |
There was a problem hiding this comment.
I am not sure that rustfmt removes trailing commas but they should be removed.
rust/src/wrapper/worksheet.rs
Outdated
| /// src="https://rustxlsxwriter.github.io/images/worksheet_set_freeze_panes_top_cell.png"> | ||
| /// | ||
| #[wasm_bindgen(js_name = "setFreezePanesTopCell", skip_jsdoc)] | ||
| pub fn set_freeze_panes_top_cell(&self, row: xlsx::RowNum, col: xlsx::ColNum,) -> WasmResult<Worksheet> { |
|
I forgot to mention, could you add a test for both methods? |
|
Oh, forgot to add test for setFreezePanesTopCell |
|
The trailing commas seems to be added automatically by |
tamaroning
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19