Skip to content

fix(driver): missing dirname() and wrong RPATH separator on macOS #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CoelacanthusHex merged 2 commits into from
Oct 13, 2025
Merged

fix(driver): missing dirname() and wrong RPATH separator on macOS #389

CoelacanthusHex merged 2 commits into from
Oct 13, 2025

Conversation

@CoelacanthusHex
Copy link
Contributor

@CoelacanthusHex CoelacanthusHex commented Oct 13, 2025

No description provided.

@CoelacanthusHex CoelacanthusHex requested a review from septs October 13, 2025 15:18
@CoelacanthusHex
fix(driver): missing dirname() on macOS
ed69d1c 
Signed-off-by: Coelacanthus <uwu@coelacanthus.name>
@septs
Copy link
Contributor

septs commented Oct 13, 2025 

$ ./lpac
dyld[3205]: Library not loaded: @rpath/libeuicc-driver-loader.2.dylib
  Referenced from: <1AEAB5B2-5106-3E16-9A4B-D2AB3D1CC50B> /Users/septs/Downloads/lpac-darwin-universal/lpac
  Reason: tried: '@loader_path:@loader_path/lib/libeuicc-driver-loader.2.dylib' (no such file), '@loader_path:@loader_path/lib/libeuicc-driver-loader.2.dylib' (no such file)
[1]    3205 abort      ./lpac

@CoelacanthusHex
fix(standalone): use semicolon-separated list so CMake convert to pla…
fb8da75 
…tform separator

Colon-separated list is only supported by GNU/BSD.

Signed-off-by: Coelacanthus <uwu@coelacanthus.name>
@CoelacanthusHex CoelacanthusHex changed the title fix(driver): missing dirname() on macOS fix(driver): missing dirname() and wrong RPATH separator on macOS Oct 13, 2025
@CoelacanthusHex CoelacanthusHex merged commit 2768143 into estkme-group:main Oct 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@septs septs septs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CoelacanthusHex @septs