fix(driver): 'json_request' interface was changed in b23f0e4 #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yeah. The mixed style is mainly because we originally wrote this project with C89, where no bool type. When we switch to C99 (with some C11 features), we don't perform a complete refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a refactoring #270, the skdio driver stopped working correctly.
It turned out that the json_request function previously returned an int and zero in the positive case.
After the refactoring, the positive result was true—the behavior was reversed.
The patch only changes the function's usage, although the style should have returned an int, as in all other driver functions.