fix(driver): gbinder driver compile #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CoelacanthusHex
left a comment
CoelacanthusHex
left a comment
There was a problem hiding this comment.
Please rebase onto main branch.
septs
requested changes
Dec 21, 2025
Contributor
septs
left a comment
septs
left a comment
There was a problem hiding this comment.
REJECT, please remove rpm directory
if needs, please add a packaging information to docs/LINUX-DIST.md file
Contributor
Author
|
Hi! I have resolved the conflicts and removed the spec from the PR branch (I uploaded it without realizing that the PR was still active, so I moved it to another branch so that it would not affect the PR). |
septs
reviewed
Dec 21, 2025
Contributor
There was a problem hiding this comment.
You should assume your users know how to use it and only provide KEY INFORMATION.
Contributor
|
please split as three pull requests
|
Contributor
Author
Thanks, I will split this in two PR, because "fix: dynamic drvier detection for SailfishOS" is solved in #401 |
juanro49
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes correct the compilation of the gbinder driver by linking the precompiled euicc and lpac-utils libraries included in the repository.