Fix template loading error handling for content types #956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When creating content using the "Create content" button with a content type that has a template defined, the template was not being applied. This occurred because template loading errors were not properly handled, causing the content creation process to fail silently and fall back to creating content without the template.
Root Cause
The
ArticleHelper.getContents()
method did not have proper error handling aroundworkspace.fs.readFile()
. When a template file doesn't exist or can't be read, this method throws an error that bubbles up and causes the template loading to fail silently.Solution
Added comprehensive error handling to ensure template loading errors are handled gracefully:
ArticleHelper.getContents()
- Prevents file reading errors from crashing the processContentType.create()
- Provides specific error handling for content type templatesExample
Before this fix:
If
project.md
doesn't exist → Silent failure, no template applied, no user feedbackAfter this fix:
Impact
Fixes #950.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.