source-google-sheets: update properties location in JSON schema #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1b7eff0e5ecf774ee84f773caa6bda213afa21f8 in estuary/flow changed where properties live within the JSON schema. `source-google-sheets` needs to look in the new location for properties, otherwise the connector will crash with a `KeyError`.
Alex-Bair
deleted the
bair/source-google-sheets-update-properties-location-in-json-schema
branch
Alex-Bair
added a commit
that referenced
this pull request
Aug 28, 2025
Alex-Bair
added a commit
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1b7eff0e5ecf774ee84f773caa6bda213afa21f8 in estuary/flow changed where properties live within the JSON schema.
source-google-sheetsneeds to look in the new location for properties, otherwise the connector will crash with aKeyError.For reference, this is what
stream.json_schemalooks like inparse_sheet_and_column_names_from_catalog:{ "$defs": { "flow://connector-schema": { "$id": "flow://connector-schema", "$schema": "http://json-schema.org/draft-07/schema#", "properties": { "my_field": { "type": "string" }, "another_field": { "type": "string" }, "row_id": { "type": "integer" } }, "required": [ "row_id" ], "type": "object" } }, "$ref": "flow://connector-schema" }