source-tiktok-marketing: patch out date-time format
#346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiktok recently changed their API to have datetime fields return values that don't comply with the ISO 8601 format. Meaning that in order to avoid schema violation errors, all those fields shouldn't have a `"format": "date-time"` in the document schema We previously tried to remove these formats in #343, but formats defined by the connector need patched out with `null` to remove them per JSON merge semantics. This commit does that for the currently patched streams and for all other discovered streams that had `"format": "date-time"` for one or more fields.
Alex-Bair
deleted the
bair/source-tiktok-marketing-patch-out-format-datetime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiktok recently changed their API to have datetime fields return values that don't comply with the ISO 8601 format. Meaning that in order to avoid schema violation errors, all those fields shouldn't have a
"format": "date-time"in the document schemaWe previously tried to remove these formats in #343, but formats defined by the connector need patched out with
nullto remove them per JSON merge semantics. This PR does that for the currently patched streams and for all other discovered streams that had"format": "date-time"for one or more fields.I confirmed only
"format": "date-time"is removed from the streams' schemas by comparing the discovery results offlowctl raw discover --source flow.yamlbefore and after updating the stream patches.