estuary-cdk: retry connection timeouts#3065
Merged
Conversation
It's a good idea to retry connection timeouts a few times in case of intermittent errors from flaky APIs. This is safe to do in the request() method since it consumes the entire response body before returning, unlike request_lines() and request_stream() which yield chunks that may have already been processed before a timeout occurs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
It's a good idea to retry connection timeouts a few times in case of intermittent errors from flaky APIs. This is safe to do in the
request()method since it consumes the entire response body before returning, unlikerequest_lines()andrequest_stream()which yield chunks that may have already been processed before a timeout occurs.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested the behavior with a small script. Confirmed a request is retried if a
ConnectionTimeoutErroris raised, and the error bubbles up once the request is attempted more thanmax_attemptstimes.This change is