Skip to content

estuary-cdk: remove default _meta value from document schemas #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex-Bair merged 3 commits into from
Aug 22, 2025
Merged

estuary-cdk: remove default _meta value from document schemas #3211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb174b3
estuary-cdk: remove BaseDocument's default annotation for _meta
Alex-Bair Aug 21, 2025
e191448
source-{various CDK connectors}: remove _meta's default annotation
Alex-Bair Aug 21, 2025
37b504d
source-{various CDK connectors}: update snapshots to include new fields
Alex-Bair Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion estuary-cdk/estuary_cdk/capture/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ class Meta(BaseModel):
)

meta_: Meta = Field(
default=Meta(op="u"), alias="_meta", description="Document metadata"
default_factory=lambda: BaseDocument.Meta(op="u"),
Comment thread
jgraettinger marked this conversation as resolved.
alias="_meta",
description="Document metadata",
)


Expand Down
24 changes: 0 additions & 24 deletions source-apple-app-store/tests/snapshots/snapshots__discover__stdout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"app_id": {
Expand Down Expand Up @@ -133,10 +129,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"app_id": {
Expand Down Expand Up @@ -244,10 +236,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"app_id": {
Expand Down Expand Up @@ -313,10 +301,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"app_id": {
Expand Down Expand Up @@ -404,10 +388,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"app_id": {
Expand Down Expand Up @@ -500,10 +480,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"app_id": {
Expand Down
2 changes: 1 addition & 1 deletion source-asana/tests/snapshots/snapshots__capture__capture.stdout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"uuid": "DocUUIDPlaceholder-329Bb50aa48EAa9ef"
},
"archived": false,
"color": "dark-teal",
"color": "aqua",
"created_at": "redacted-timestamp",
"current_status": null,
"custom_fields": [],
Expand Down
2 changes: 2 additions & 0 deletions source-braintree-native/tests/snapshots/snapshots__capture__capture.stdout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@
"uuid": "DocUUIDPlaceholder-329Bb50aa48EAa9ef"
},
"account_funding_transaction": false,
"ach_reject_reason": null,
"ach_return_code": null,
"ach_return_responses": [],
"acquirer_reference_number": null,
Expand Down Expand Up @@ -622,6 +623,7 @@
"transactions": [
{
"account_funding_transaction": false,
"ach_reject_reason": null,
"ach_return_code": null,
"acquirer_reference_number": null,
"add_ons": [],
Expand Down
36 changes: 0 additions & 36 deletions source-braintree-native/tests/snapshots/snapshots__discover__capture.stdout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -87,10 +83,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down Expand Up @@ -152,10 +144,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down Expand Up @@ -216,10 +204,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -268,10 +252,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down Expand Up @@ -332,10 +312,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -383,10 +359,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -435,10 +407,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down Expand Up @@ -499,10 +467,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down
8 changes: 0 additions & 8 deletions source-datadog/tests/snapshots/snapshots__discover__stdout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down Expand Up @@ -127,10 +123,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down
32 changes: 0 additions & 32 deletions source-front/tests/snapshots/snapshots__discover__capture.stdout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -86,10 +82,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -137,10 +129,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -188,10 +176,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -239,10 +223,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -290,10 +270,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down Expand Up @@ -353,10 +329,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down Expand Up @@ -416,10 +388,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"id": {
Expand Down
28 changes: 0 additions & 28 deletions source-genesys/tests/snapshots/snapshots__discover__capture.stdout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -86,10 +82,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
},
"conversationId": {
Expand Down Expand Up @@ -155,10 +147,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -206,10 +194,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -257,10 +241,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -308,10 +288,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down Expand Up @@ -359,10 +335,6 @@
"properties": {
"_meta": {
"$ref": "#/$defs/Meta",
"default": {
"op": "u",
"row_id": -1
},
"description": "Document metadata"
}
},
Expand Down
Loading
Loading