materialize-snowflake: revert reencrypt files on recovery#4231
Closed
danielnelson wants to merge 4 commits intomainfrom
Closed
materialize-snowflake: revert reencrypt files on recovery#4231danielnelson wants to merge 4 commits intomainfrom
danielnelson wants to merge 4 commits intomainfrom
Conversation
danielnelson
requested review from
a team and
williamhbaker
and removed request for
a team and
williamhbaker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
If the first time the connector uses the new checkpoint is during recovery, the key will not be set. In this case we guessed that the channel key is the same but if this is incorrect then we can't rename the blob. This situation came up much faster than expected, so we think it may be more common than expected.
Workflow steps:
No changes
Documentation links affected:
None.
Notes for reviewers:
(anything that might help someone review this PR)