fix(clickhouse): do not double-escape JSON-encoded fields#4232
Merged
jacobmarble merged 3 commits intomainfrom Apr 13, 2026
Merged
fix(clickhouse): do not double-escape JSON-encoded fields#4232jacobmarble merged 3 commits intomainfrom
jacobmarble merged 3 commits intomainfrom
Conversation
jacobmarble
force-pushed
the
jgm-clickhouse-json
branch
from
990ca09 to
2967154
Compare
mdibaiee
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The Clickhouse materializer double-escapes object/array/multiple type columns because
Load()depends on Clickhouse functionstoJSONString(map(...))to reconstruct, which does NOT JSON-decode those stringsInstead, we need to build the top-level JSON string manually by concatenating a bunch of
{,},:,,, column names, variables, etc.Workflow steps:
This fixes in the
Load()method of the Clickhouse materializer.Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)