materialize-snowflake: skip rename if no encryption key#4235
Merged
danielnelson merged 1 commit intomainfrom Apr 13, 2026
Merged
materialize-snowflake: skip rename if no encryption key#4235danielnelson merged 1 commit intomainfrom
danielnelson merged 1 commit intomainfrom
Conversation
Checkpoints created before the encryption key was added do not have the information required to be rewritten and renamed. Guessing that the current channel key was the one used to write the files originally did not always works. It should be safer to use the previous strategy of doing a registration on the original file.
mdibaiee
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoints created before the encryption key was added do not have the information required to be rewritten and renamed. The previous change guessed that the current channel key was the one used to write the files originally but it did not always work. With this change we use the prior strategy of doing a registration on the original file.
related: #4047
Workflow steps:
No changes
Documentation links affected:
None
Notes for reviewers: