Merged
Conversation
478f596 to
8aad682
Compare
cda30a7 to
0d25dad
Compare
Alex-Bair
reviewed
Apr 20, 2026
Member
Alex-Bair
left a comment
There was a problem hiding this comment.
Based on the approach we took in #4266, I think we'll need a symlink for source-appsflyer/Dockerfile to estuary-cdk/webhook-capture.Dockerfile, is that right?
Also, what do you think about adding a simple test to ensure that the Dockerfile used by source-appsflyer contains EXPOSE 8080? That would help ensure the tests don't pass & the connector image doesn't get built without the Dockerfile exposing that port.
0d25dad to
029bfc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new connector for the AppsFlyer marketing analytics platform.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested through a local deployment.
geo_daily_reportbackfills existing test data.