Skip to content

source-appsflyer: new connector#4260

Merged
nicolaslazo merged 1 commit intomainfrom
nlazo/source-appsflyer
Apr 20, 2026
Merged

source-appsflyer: new connector#4260
nicolaslazo merged 1 commit intomainfrom
nlazo/source-appsflyer

Conversation

@nicolaslazo
Copy link
Copy Markdown
Contributor

@nicolaslazo nicolaslazo commented Apr 17, 2026

Description:

Adds a new connector for the AppsFlyer marketing analytics platform.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

Tested through a local deployment. geo_daily_report backfills existing test data.

@nicolaslazo nicolaslazo requested a review from Alex-Bair April 17, 2026 14:44
@nicolaslazo nicolaslazo self-assigned this Apr 17, 2026
@nicolaslazo nicolaslazo force-pushed the nlazo/source-appsflyer branch from 478f596 to 8aad682 Compare April 17, 2026 22:41
@nicolaslazo nicolaslazo marked this pull request as ready for review April 17, 2026 22:42
@nicolaslazo nicolaslazo force-pushed the nlazo/source-appsflyer branch 2 times, most recently from cda30a7 to 0d25dad Compare April 20, 2026 13:25
Copy link
Copy Markdown
Member

@Alex-Bair Alex-Bair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the approach we took in #4266, I think we'll need a symlink for source-appsflyer/Dockerfile to estuary-cdk/webhook-capture.Dockerfile, is that right?

Also, what do you think about adding a simple test to ensure that the Dockerfile used by source-appsflyer contains EXPOSE 8080? That would help ensure the tests don't pass & the connector image doesn't get built without the Dockerfile exposing that port.

@nicolaslazo nicolaslazo force-pushed the nlazo/source-appsflyer branch from 0d25dad to 029bfc7 Compare April 20, 2026 14:11
Copy link
Copy Markdown
Member

@Alex-Bair Alex-Bair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolaslazo nicolaslazo merged commit f345158 into main Apr 20, 2026
119 of 130 checks passed
@nicolaslazo nicolaslazo deleted the nlazo/source-appsflyer branch April 20, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants